Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][FWD] jsonifier: misc imp/fix from 16.0 and 14.0 #3206

Merged

Conversation

simahawk
Copy link
Contributor

Followup of #3205

lmignon and others added 10 commits February 21, 2025 12:28
If a field name into the parser definition doesn't exist into the model but is resolved by a callable, call the method. Prior to this change, it was o more possible to define computed json value for custome keys
Quite handy to take full control of the final result.
Orig commit msg:

[ADD] use jsonifier features to retund postprocessed values, containing
field string as well

Better Version, not using function features , leaves parser syntax
intact.

[FIX] Review fixes

[FIX] small comment and style fix
An invalid field must be skipped in any case if not in strict mode.
Error message has been downgraded to warning since is not really broken
till you use string mode.

Log tests reworked.
The resolver was returned as a full recordset,
hence its cursor could diverge from the original one
and get closed while the other was still active.
@simahawk
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3206-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 24, 2025
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name server-tools --branch 18.0 --addons-dir /tmp/tmpyxh6ahe_ --commit failed with output:

Both .md and .rst found for USAGE. Please remove one of /tmp/tmpyxh6ahe_/jsonifier/readme/USAGE.rst or /tmp/tmpyxh6ahe_/jsonifier/readme/USAGE.md.

@simahawk
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3206-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 72f74aa. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit e11e694 into OCA:18.0 Feb 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants