-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][FWD] jsonifier: misc imp/fix from 16.0 and 14.0 #3206
[18.0][FWD] jsonifier: misc imp/fix from 16.0 and 14.0 #3206
Conversation
If a field name into the parser definition doesn't exist into the model but is resolved by a callable, call the method. Prior to this change, it was o more possible to define computed json value for custome keys
Quite handy to take full control of the final result.
Orig commit msg: [ADD] use jsonifier features to retund postprocessed values, containing field string as well Better Version, not using function features , leaves parser syntax intact. [FIX] Review fixes [FIX] small comment and style fix
An invalid field must be skipped in any case if not in strict mode. Error message has been downgraded to warning since is not really broken till you use string mode. Log tests reworked.
The resolver was returned as a full recordset, hence its cursor could diverge from the original one and get closed while the other was still active.
/ocabot merge minor |
What a great day to merge this nice PR. Let's do it! |
@simahawk The merge process could not be finalized, because command
|
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 72f74aa. Thanks a lot for contributing to OCA. ❤️ |
Followup of #3205